Optimize bürgergeld__in_anderer_bg_als_kindergeldempfänger
#1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation build overviewFiles changed
Show files (3) | 3 modified | 0 added | 0 deleted
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Aug 13, 2025
hmgaudecker
reviewed
Aug 14, 2025
hmgaudecker
reviewed
Aug 14, 2025
JuergenWiemers
force-pushed
the
JW/PR/optimization
branch
from
de94ca8 to
38416f6
Compare
|
And thanks to @mj023 for identifying the source of the quadratic memory explosion in JAX! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Twin PR" to ttsim-dev/ttsim#41. Uses the optimized
tt.shared.joinin that PR.[EDIT: Just realized I need to change this twice, once for "bürgergeld" and once for "arbeitslosengeld_2".]
[EDIT2: I added the blocked label because this should only be merged after ttsim#41 is accepted. It really wouldn't help to use the very inefficient current implementation of
tt.shared.join. 😅][EDIT3: Pushed a commit to fix the quadratic memory scaling for JAX, as discussed in https://github.com/ttsim-dev/ttsim/pull/41]