Skip to content

Conversation

simonLeary42
Copy link
Contributor

@simonLeary42 simonLeary42 commented Oct 2, 2025

Many of the functions in project_openldap.utils are generic for any LDAP entry, with unnecessarily specific names. I want to import these functions and use them for allocation_ldap.

All these renames were done with vscode/pylance rename symbol feature, which promises to fix all references to a symbol across the entire codebase.

other changes:

  • update_project_posixgroup_in_openldap -> update_project_posixgroup_description_in_openldap is actually less generic

@simonLeary42 simonLeary42 force-pushed the project-openldap-rename branch 2 times, most recently from 52e4907 to 07a3b23 Compare October 2, 2025 21:12
@simonLeary42
Copy link
Contributor Author

From @ds-04 (author of project_openldap) on Slack:

this is much needed, and i thought about it doing it .. but it got to the point where i just needed the code in core

only comment is perhaps .. do we use posixGroup in the name .. or posixgroup

e.g. OpenLDAP terms in the functions names .. and their caseing

I dont care much about the capitalization, feel free to suggest edits on my PR and I will apply them

yeah im not that bothered either

its fine i think

ive not tested it .. but it looked fine

@ds-04
Copy link
Contributor

ds-04 commented Oct 3, 2025

agree with transcript above

@simonLeary42 simonLeary42 force-pushed the project-openldap-rename branch from 07a3b23 to a4897a2 Compare October 7, 2025 14:50
Signed-off-by: Simon Leary <simon.leary42@proton.me>
@aebruno aebruno merged commit 5d1cf59 into ubccr:main Oct 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants