Skip to content

csplit: detect and report write errors #9855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sylvestre merged 3 commits into from
Dec 31, 2025
Merged

csplit: detect and report write errors #9855

sylvestre merged 3 commits into from
Dec 31, 2025
+56 −11

Conversation

@ChrisDryden
Copy link
Collaborator

@ChrisDryden ChrisDryden commented Dec 26, 2025 •
edited
Loading

This is a fix for csplit that now works with the new integration test that coreutils is using for that package.

It fixes the following issues:

@ChrisDryden ChrisDryden mentioned this pull request Dec 26, 2025
Closed
@ChrisDryden ChrisDryden force-pushed the csplit-detect-write-errors branch 2 times, most recently from 841bddd to fd299f0 Compare December 26, 2025 05:04
@oech3

This comment was marked as resolved.

Sign in to view
@github-actions
Copy link

github-actions bot commented Dec 26, 2025

GNU testsuite comparison:

Note: The gnu test tests/pr/pr-tests was skipped on 'main' but is now failing.

@oech3 oech3 mentioned this pull request Dec 26, 2025
Closed
@ChrisDryden ChrisDryden force-pushed the csplit-detect-write-errors branch from f959aed to 5eaecbe Compare December 26, 2025 20:01
@ChrisDryden ChrisDryden mentioned this pull request Dec 26, 2025
Open
@github-actions
Copy link

github-actions bot commented Dec 26, 2025

GNU testsuite comparison:

Note: The gnu test tests/pr/pr-tests was skipped on 'main' but is now failing.

@oech3 oech3 mentioned this pull request Dec 27, 2025
Merged
@oech3

This comment was marked as resolved.

Sign in to view
@ChrisDryden ChrisDryden force-pushed the csplit-detect-write-errors branch from 5eaecbe to 47588fc Compare December 28, 2025 14:02
@ChrisDryden ChrisDryden marked this pull request as ready for review December 28, 2025 14:05
@github-actions
Copy link

github-actions bot commented Dec 28, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/csplit/csplit-io-err is no longer failing!

@github-actions
Copy link

github-actions bot commented Dec 29, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/csplit/csplit-io-err is no longer failing!
Congrats! The gnu test tests/tty/tty-eof is no longer failing!

@ChrisDryden ChrisDryden force-pushed the csplit-detect-write-errors branch from d91bf90 to 5be61ac Compare December 30, 2025 20:52
@github-actions
Copy link

github-actions bot commented Dec 30, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/csplit/csplit-io-err is no longer failing!

sylvestre
sylvestre approved these changes Dec 30, 2025
View reviewed changes
Copy link
Contributor

@sylvestre sylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for the CI to finish

@sylvestre sylvestre merged commit a297d26 into uutils:main Dec 31, 2025
129 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChrisDryden @oech3 @sylvestre