Skip to content

Conversation

@nilanshu-sharma
Copy link
Collaborator

@nilanshu-sharma nilanshu-sharma commented Nov 7, 2025

Change Summary:

  1. Adding custom responses for the following commands:

    • CLUSTER SLOTS
    • CLUSTER SLOT-STATS
    • CLUSTER LINKS
  2. Removing docker network to make cluster-mode valkey directly accessible to integration tests while testing locally on laptop.

  3. Restoring platform availability macros causing builds to fail

  4. Also realized that the Integration tests meant to cluster-mode features are not running in the CI, so CI needs to be enhanced to run cluster mode related docker dependencies. For now the verification of new integration tests is done locally.

@nilanshu-sharma nilanshu-sharma force-pushed the custom-cluster-command-types branch from 5023075 to 2bc45cb Compare November 7, 2025 02:22
Nilanshu Sharma added 2 commits November 7, 2025 11:07
Signed-off-by: Nilanshu Sharma <nilanshu_sharma@apple.com>
Signed-off-by: Nilanshu Sharma <nilanshu_sharma@apple.com>
@nilanshu-sharma nilanshu-sharma force-pushed the custom-cluster-command-types branch from 2bc45cb to cbe091e Compare November 7, 2025 19:28
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

✅ Pull request no significant performance differences ✅

Summary

New baseline 'pull_request' is WITHIN the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host 'a247f4952bd8' with 4 'x86_64' processors with 15 GB memory, running:
#18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025

ValkeyBenchmarks

Client: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 77 77 80 81 82 82 82 6
pull_request 76 78 78 80 82 82 82 6
Δ -1 1 -2 -1 0 0 0 0
Improvement % 1 -1 2 1 0 0 0 0

Client: GET benchmark | parallel 20 | 20 concurrent connections metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 72 77 80 83 85 87 87 28
pull_request 71 78 80 83 86 89 89 28
Δ -1 1 0 0 1 2 2 0
Improvement % 1 -1 0 0 -1 -2 -2 0

Connection: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 4 4 4 4 4 4 4 8
pull_request 4 4 4 4 4 4 4 8
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

Connection: GET benchmark – NoOpTracer metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 7 8 8 10 11 11 11 8
pull_request 7 8 8 10 11 11 11 8
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

Connection: Pipeline array benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 33 33 34 34 34 34 34 6
pull_request 33 33 34 34 34 34 34 6
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

Connection: Pipeline benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 33 33 33 34 34 34 34 6
pull_request 33 33 33 34 34 34 34 6
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

HashSlot – {user}.whatever metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 18
pull_request 0 0 0 0 0 0 0 19
Δ 0 0 0 0 0 0 0 1
Improvement % 0 0 0 0 0 0 0 1

ValkeyCommandEncoder – Command with 7 words metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 755
pull_request 0 0 0 0 0 0 0 756
Δ 0 0 0 0 0 0 0 1
Improvement % 0 0 0 0 0 0 0 1

ValkeyCommandEncoder – Simple GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 1919
pull_request 0 0 0 0 0 0 0 1917
Δ 0 0 0 0 0 0 0 -2
Improvement % 0 0 0 0 0 0 0 -2

ValkeyCommandEncoder – Simple MGET 15 keys metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 362
pull_request 0 0 0 0 0 0 0 363
Δ 0 0 0 0 0 0 0 1
Improvement % 0 0 0 0 0 0 0 1

Signed-off-by: Nilanshu Sharma <nilanshu_sharma@apple.com>
@nilanshu-sharma nilanshu-sharma changed the title [Work in Progress]: Custom responses for cluster commands Custom responses for cluster commands Nov 7, 2025
Nilanshu Sharma added 3 commits November 7, 2025 13:23
Signed-off-by: Nilanshu Sharma <nilanshu_sharma@apple.com>
Signed-off-by: Nilanshu Sharma <nilanshu_sharma@apple.com>
Signed-off-by: Nilanshu Sharma <nilanshu_sharma@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants