Skip to content

Custom responses for cluster commands #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Custom responses for cluster commands #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
79a927a
Custom responses for cluster commands
Nov 7, 2025
cbe091e
Fixing Custom response object fields
Nov 7, 2025
fce444c
Fixing soundness checks
Nov 7, 2025
9e58e9a
Fixing stylechecks and restoring availability macros
Nov 7, 2025
c69dc68
Fixing format checks
Nov 7, 2025
28496ed
Disabling intergration test conditionally
Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions Sources/Valkey/Commands/ClusterCommands.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,6 @@ public enum CLUSTER {
/// Returns a list of all TCP links to and from peer nodes.
@_documentation(visibility: internal)
public struct LINKS: ValkeyCommand {
public typealias Response = RESPToken.Array

@inlinable public static var name: String { "CLUSTER LINKS" }

@inlinable public init() {
Expand Down Expand Up @@ -789,8 +787,6 @@ public enum CLUSTER {
}
}
}
public typealias Response = RESPToken.Array

@inlinable public static var name: String { "CLUSTER SLOT-STATS" }

public var filter: Filter
Expand All @@ -807,8 +803,6 @@ public enum CLUSTER {
/// Returns the mapping of cluster slots to nodes.
@_documentation(visibility: internal)
public struct SLOTS: ValkeyCommand {
public typealias Response = RESPToken.Array

@inlinable public static var name: String { "CLUSTER SLOTS" }

@inlinable public init() {
Expand Down Expand Up @@ -1068,7 +1062,7 @@ extension ValkeyClientProtocol {
/// - Response: [Array]: An array of cluster links and their attributes.
@inlinable
@discardableResult
public func clusterLinks() async throws -> RESPToken.Array {
public func clusterLinks() async throws -> CLUSTER.LINKS.Response {
try await execute(CLUSTER.LINKS())
}

Expand Down Expand Up @@ -1229,7 +1223,7 @@ extension ValkeyClientProtocol {
/// - Response: [Array]: Array of nested arrays, where the inner array element represents a slot and its respective usage statistics.
@inlinable
@discardableResult
public func clusterSlotStats(filter: CLUSTER.SLOTSTATS.Filter) async throws -> RESPToken.Array {
public func clusterSlotStats(filter: CLUSTER.SLOTSTATS.Filter) async throws -> CLUSTER.SLOTSTATS.Response {
try await execute(CLUSTER.SLOTSTATS(filter: filter))
}

Expand All @@ -1244,7 +1238,7 @@ extension ValkeyClientProtocol {
/// - Response: [Array]: Nested list of slot ranges with networking information.
@inlinable
@discardableResult
public func clusterSlots() async throws -> RESPToken.Array {
public func clusterSlots() async throws -> CLUSTER.SLOTS.Response {
try await execute(CLUSTER.SLOTS())
}

Expand Down
Loading
Loading