Fix bug where unmade splits become 0 and unbeatable and unsaveable #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 29, 2025 17:52
Fix for wins1ey#81 on upstream. Thank you Des for the help
Loomeh
approved these changes
Sep 29, 2025
Loomeh
previously approved these changes
Sep 29, 2025
They weren't saving because they weren't being checked individually for not being 0 or llongmax
EXtremeExploit
previously approved these changes
Oct 9, 2025
|
by the way, the commit's email is not connected to your github account (they appear as anonymously named commits) |
Loomeh
requested changes
Oct 9, 2025
Comment on lines
422
to
434
| // Only save the split if it's above 0. Otherwise it's impossible to beat 0 | ||
| if (game->split_times[i] != 0 && game->split_times[i] != LLONG_MAX) { | ||
| ls_time_string_serialized(str, game->split_times[i]); | ||
| json_object_set_new(split, "time", json_string(str)); | ||
| } | ||
| if (game->best_splits[i] == 0 && game->best_splits[i] != LLONG_MAX) { | ||
| ls_time_string_serialized(str, game->best_splits[i]); | ||
| json_object_set_new(split, "best_time", json_string(str)); | ||
| } | ||
| if (game->best_segments[i] != 0 && game->best_segments[i] != LLONG_MAX) { | ||
| ls_time_string_serialized(str, game->best_segments[i]); | ||
| json_object_set_new(split, "best_segment", json_string(str)); | ||
| } |
There was a problem hiding this comment.
Your comment says you're checking if the split time is above zero but it only checks if the split time is not equal to zero (same with checking if it's below LLONG_MAX). Even if this is unlikely to cause any issues with use of the program, it would probably be better for this to be changed to a greater than > and less than < check to avoid issues in the future.
Loomeh
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #81 on upstream. Thank you Des for the help