XWIKI-11250: FlamingoThemes space doesn't display any panels #4564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed the special Preferences regarding panels in the colortheme section * Added a few lines to disable the panels specifically when there's the preview in edit mode.
mflorea
reviewed
Sep 29, 2025
| ## Always hide both side panel columns | ||
| #set($showLeftPanels = "0") | ||
| #set($showRightPanels = "0") | ||
| <script>document.getElementById("body").classList.add("hidelefthideright");</script> |
There was a problem hiding this comment.
I don't like the inline script. If the problem is that $showLeftPanels and $showRightPanels are set too late, then maybe we can set them in a UI extension that is executed before they are used (checking before that we are in edit mode and inside the FlamingoThemesCode space, of course).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-11250
Changes
Description
Clarifications
Screenshots & Video
Here are what the colortheme pages look like after applying the changes:
Executed Tests
Built the changes with
mvn clean install -f xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-theme/xwiki-platform-flamingo-theme-ui -Pqualityand then tested them withmvn clean install -f xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-theme/xwiki-platform-flamingo-theme-test/xwiki-platform-flamingo-theme-test-dockerTested the changes locally.
Expected merging strategy