Skip to content

XWIKI-11250: FlamingoThemes space doesn't display any panels #4564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

XWIKI-11250: FlamingoThemes space doesn't display any panels #4564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...eme/xwiki-platform-flamingo-theme-ui/src/main/resources/FlamingoThemes/WebPreferences.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1333,10 +1333,10 @@
<rightPanelsWidth>---</rightPanelsWidth>
</property>
<property>
<showLeftPanels>0</showLeftPanels>
<showLeftPanels/>
</property>
<property>
<showRightPanels>0</showRightPanels>
<showRightPanels/>
</property>
<property>
<showannotations/>
Expand Down
4 changes: 4 additions & 0 deletions ...eme/xwiki-platform-flamingo-theme-ui/src/main/resources/FlamingoThemesCode/ThemeSheet.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,10 @@
&lt;div class="row"&gt;
#if($isEdit)
#displayVariablesPanel()
## Always hide both side panel columns
#set($showLeftPanels = "0")
#set($showRightPanels = "0")
&lt;script&gt;document.getElementById("body").classList.add("hidelefthideright");&lt;/script&gt;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the inline script. If the problem is that $showLeftPanels and $showRightPanels are set too late, then maybe we can set them in a UI extension that is executed before they are used (checking before that we are in edit mode and inside the FlamingoThemesCode space, of course).

#else
#displayHiddenVariables()
#end
Expand Down