XWIKI-23523: Livedata crash with NPE when used with custom data source #4571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Josue-T ! |
* Add test to avoid regression
Thank you for the suggestion. Added a test to ensure that we don't have any regression around this. |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-23523
Changes
Description
In some cases
config.getMeta()return null, so we need to handle this case.Clarifications
It was probably a regression introduced by bad5aab#diff-2ccf904ad681c93a0abc3a40d6c4c9c7ff1faaf74ec8ecb94607554a4b55908eR115-R116
Executed Tests
Tested with my custom Livedata and it seem fixing the issue.
Expected merging strategy