Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,11 @@ private LiveDataConfiguration mergeBaseConfig(LiveDataConfiguration config) thro
// Prevent null values (make the configuration explicit).
mergedConfig.initialize();

handleLayouts(config.getMeta().getLayouts(), mergedConfig.getMeta());
Collection<LiveDataLayoutDescriptor> layout = null;
if (config.getMeta() != null) {
layout = config.getMeta().getLayouts();
}
handleLayouts(layout, mergedConfig.getMeta());
handlePageSizes(mergedConfig);

// Translate using the context locale.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,22 @@ void withInitialize() throws Exception
this.resolver.resolve(this.resolver.resolve(config)));
}

/**
* Test to avoid regression on XWIKI-23523.
* We need to ensure that we can resolve a configuration with meta=null.
*/
@Test
void withMetaNull() throws Exception
{
LiveDataConfiguration config = new LiveDataConfiguration();
config.initialize();
config.setMeta(null);
String expected = FileUtils.readFileToString(new File("src/test/resources/withInitialize.json"),
Charset.defaultCharset());
assertEquals(this.objectMapper.readValue(expected, LiveDataConfiguration.class),
this.resolver.resolve(this.resolver.resolve(config)));
}

private static Stream<String[]> getTestData() throws Exception
{
return DATA_PROVIDER.getTestData(new File("src/test/resources/DefaultLiveDataConfigurationResolver.test"));
Expand Down