Skip to content

deps: Upgrade Flutter to 3.33.0-1.0.pre.1149 #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

deps: Upgrade Flutter to 3.33.0-1.0.pre.1149 #1755

wants to merge 1 commit into from

Conversation

sm-sayedi
Copy link
Collaborator

And update Flutter's supporting libraries to match.

With this upgrade, we can now use the route transition duration in tests to wait the minimum amount of time needed for the route animation to complete.

Related upstream PR: flutter/flutter#171109

@sm-sayedi sm-sayedi force-pushed the flutter-upgrade-250726 branch from fed9b23 to 80beb5c Compare July 26, 2025 02:28
@sm-sayedi sm-sayedi mentioned this pull request Jul 26, 2025
Merged
@sm-sayedi
Copy link
Collaborator Author

sm-sayedi commented Jul 26, 2025 •
edited
Loading

CI is failing for the android build with the following output: (#mobile-dev-help > CI fails for android build)

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app_settings:compileDebugKotlin'.
> Error while evaluating property 'friendPathsSet$kotlin_gradle_plugin_common' of task ':app_settings:compileDebugKotlin'.
   > Could not resolve all files for configuration ':app_settings:debugCompileClasspath'.
      > Could not find io.flutter:flutter_embedding_debug:1.0.0-2de0d89afa16c5e7e441538a8c2ca0cc6754fa36.
        Required by:
            project :app_settings

@sm-sayedi sm-sayedi requested a review from rajveermalviya July 26, 2025 03:29
@sm-sayedi sm-sayedi added the maintainer review PR ready for review by Zulip maintainers label Jul 26, 2025
@sm-sayedi sm-sayedi force-pushed the flutter-upgrade-250726 branch 3 times, most recently from 092c4b9 to fd8323e Compare July 26, 2025 18:07
@sm-sayedi sm-sayedi changed the title deps: Upgrade Flutter to 3.33.0-1.0.pre-1142 deps: Upgrade Flutter to 3.33.0-1.0.pre.1145 Jul 26, 2025
@sm-sayedi sm-sayedi added the integration review Added by maintainers when PR may be ready for integration label Jul 26, 2025
@sm-sayedi sm-sayedi requested a review from gnprice July 26, 2025 18:30
@sm-sayedi
Copy link
Collaborator Author

With this upgrade, code autocompletion is not as smart as before. Opened a new thread at CZO: #mobile-dev-help > New Flutter upgrade degrades code autocompletion

rajveermalviya
rajveermalviya approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@rajveermalviya rajveermalviya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this upgrade @sm-sayedi!
LGTM.

@sm-sayedi
deps: Upgrade Flutter to 3.33.0-1.0.pre.1149
6981bb7 
And update Flutter's supporting libraries to match.
@sm-sayedi sm-sayedi force-pushed the flutter-upgrade-250726 branch from fd8323e to 6981bb7 Compare July 28, 2025 18:04
@sm-sayedi sm-sayedi changed the title deps: Upgrade Flutter to 3.33.0-1.0.pre.1145 deps: Upgrade Flutter to 3.33.0-1.0.pre.1149 Jul 28, 2025
@sm-sayedi sm-sayedi mentioned this pull request Jul 28, 2025
Merged
@gnprice gnprice mentioned this pull request Jul 28, 2025
Merged
@gnprice
Copy link
Member

gnprice commented Jul 28, 2025

Thanks.

That breakage of autocomplete looks pretty annoying — it'd be good to avoid that, until it gets fixed upstream.

In the chat thread, you found via bisect (thanks for the investigation!) that the breakage was introduced at flutter/flutter@fa80cbcbd. So let's try the commit before that one.

Conveniently that's still well after the PR you mention above, flutter/flutter#171109, which landed in flutter/flutter@9b93519.

gnprice added a commit to gnprice/zulip-flutter that referenced this pull request Jul 28, 2025
@gnprice
deps: Upgrade Flutter to 3.33.0-1.0.pre-1085
bb4915f 
And update Flutter's supporting libraries to match.

In particular this gets us TransitionDurationObserver:
  flutter/flutter#171109

We stop just before a certain Dart SDK roll:
  flutter/flutter@fa80cbcbdbdd
because that commit breaks completion in the IDE, which would be
pretty annoying for doing development.  Thanks to Sayed for
spotting that breakage and bisecting it to that commit:
  zulip#1755 (comment)
  https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/New.20Flutter.20upgrade.20degrades.20code.20autocompletion/near/2230721
@gnprice gnprice mentioned this pull request Jul 28, 2025
Merged
@gnprice
Copy link
Member

gnprice commented Jul 28, 2025

Sent #1763 to do that more constrained upgrade.

gnprice added a commit to gnprice/zulip-flutter that referenced this pull request Jul 28, 2025
@gnprice
deps: Upgrade Flutter to 3.33.0-1.0.pre-1085
339ddd6 
And update Flutter's supporting libraries to match.

In particular this gets us TransitionDurationObserver:
  flutter/flutter#171109

We stop just before a certain Dart SDK roll:
  flutter/flutter@fa80cbcbdbdd
because that commit breaks completion in the IDE, which would be
pretty annoying for doing development.  Thanks to Sayed for
spotting that breakage and bisecting it to that commit:
  zulip#1755 (comment)
  https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/New.20Flutter.20upgrade.20degrades.20code.20autocompletion/near/2230721
chrisbobbe pushed a commit to chrisbobbe/zulip-flutter that referenced this pull request Jul 29, 2025
@gnprice @chrisbobbe
deps: Upgrade Flutter to 3.33.0-1.0.pre-1085
38278d5 
And update Flutter's supporting libraries to match.

In particular this gets us TransitionDurationObserver:
  flutter/flutter#171109

We stop just before a certain Dart SDK roll:
  flutter/flutter@fa80cbcbdbdd
because that commit breaks completion in the IDE, which would be
pretty annoying for doing development.  Thanks to Sayed for
spotting that breakage and bisecting it to that commit:
  zulip#1755 (comment)
  https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/New.20Flutter.20upgrade.20degrades.20code.20autocompletion/near/2230721
@sm-sayedi
Copy link
Collaborator Author

Thanks @gnprice for the new PR. Closing this in favor of that (#1763).

@sm-sayedi sm-sayedi closed this Jul 29, 2025
gnprice added a commit to gnprice/zulip-flutter that referenced this pull request Jul 29, 2025
@gnprice
deps: Upgrade Flutter to 3.33.0-1.0.pre-1085
d903e87 
And update Flutter's supporting libraries to match.

In particular this gets us TransitionDurationObserver:
  flutter/flutter#171109

We stop just before a certain Dart SDK roll:
  flutter/flutter@fa80cbcbdbdd
because that commit breaks completion in the IDE, which would be
pretty annoying for doing development.  Thanks to Sayed for
spotting that breakage and bisecting it to that commit:
  zulip#1755 (comment)
  https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/New.20Flutter.20upgrade.20degrades.20code.20autocompletion/near/2230721
gnprice added a commit to gnprice/zulip-flutter that referenced this pull request Jul 29, 2025
@gnprice
deps: Upgrade Flutter to 3.33.0-1.0.pre-1085
6c0c1d8 
And update Flutter's supporting libraries to match.

In particular this gets us TransitionDurationObserver:
  flutter/flutter#171109

We stop just before a certain Dart SDK roll:
  flutter/flutter@fa80cbcbdbdd
because that commit breaks completion in the IDE, which would be
pretty annoying for doing development.  Thanks to Sayed for
spotting that breakage and bisecting it to that commit:
  zulip#1755 (comment)
  https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/New.20Flutter.20upgrade.20degrades.20code.20autocompletion/near/2230721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajveermalviya rajveermalviya rajveermalviya approved these changes

@gnprice gnprice Awaiting requested review from gnprice

Assignees
No one assigned
Labels
integration review Added by maintainers when PR may be ready for integration maintainer review PR ready for review by Zulip maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sm-sayedi @gnprice @rajveermalviya