-
Notifications
You must be signed in to change notification settings - Fork 109
H-5768: Extract styles from all component files in Petrinaut #8205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cf/h-5768-integrate-quick-simulation-in-edit-mode
Are you sure you want to change the base?
H-5768: Extract styles from all component files in Petrinaut #8205
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryStandardizes styling by migrating inline styles to
Written by Cursor Bugbot for commit 5e05299. This will update automatically on new commits. Configure here. |
| padding: "[5px 8px]", | ||
| border: "[1px solid rgba(0, 0, 0, 0.15)]", | ||
| borderRadius: "[3px]", | ||
| flex: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a numeric value that needs to be converted to a string with brackets to satisfy the ConditionalValue type requirement. Any numeric values in this style definition should be wrapped in brackets like '[value]'.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
| fontWeight: "medium", | ||
| color: "core.gray.80", | ||
| "&:hover": { | ||
| _hover: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing background property on entity toggle button
The entityButtonStyle is missing a background property. The old inline style included background: "none" which was lost during the refactoring. Without this, the button will render with the browser's default button background styling instead of being transparent, causing a visual regression in the diagnostics panel's collapsible entity headers.
| defaultVariants: { | ||
| selection: "none", | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hover effect overrides selection glow on transition nodes
The transitionBoxStyle CVA has a _hover rule with boxShadow in the base and selection-specific boxShadow values in the variants. Previously, the selection boxShadow was applied via inline style prop which had higher specificity than CSS :hover rules. Now both are CSS classes, so hovering over a selected transition node causes the selection glow (blue for resource selection, orange for ReactFlow selection) to be temporarily replaced by the weaker generic hover glow, reducing the visual indication that the node is selected.
21ce7f1 to
094e1a7
Compare
4ddbfe3 to
86618ff
Compare
094e1a7 to
87b914c
Compare
86618ff to
5e05299
Compare

🌟 What is the purpose of this PR?
🔗 Related links
🚫 Blocked by
🔍 What does this change?
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
turbo.json's have been updated to reflect this🐾 Next steps
🛡 What tests cover this?
❓ How to test this?
📹 Demo