-
Notifications
You must be signed in to change notification settings - Fork 75
capture-hw-details.sh: get igc64.dll version from the currenlty loaded graphics driver #5439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| pwsh -Command ' | ||
| $igc = @(Get-Process -Name dwm -Module | Where-Object ModuleName -eq 'igc64.dll') | ||
| if ($igc.Count -gt 1) { | ||
| Write-Host "MULTIPLE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a possible scenario? I understand when it comes to DriverStore (previous approach), which can contain multiple drivers, but we've switched to an approach where the driver currently in use is requested. Is it possible that multiple drivers are in use at the same time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, after updating the driver, but before reboot, It lists 2 versions of igc64 loaded for dwm.exe. I suppose this it is done on purpose to allow fast fallback on driver crashes.
For example, see #5440 (comment).
However your comment highlighted another issue: when an interactive session is present on machine, this will return "MULTIPLE" despite there's only one library, since we have 2 dwms in this case: one for a login screen, and one for a session. I'll fix it with something like sort -u
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it handles multiple objects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you plan to do if script return MULTIPLE? Will this be a signal that the machine needs to be rebooted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @kwasd
When there are multiple libigc versions in a Windows driver store, Windows CI breaks:
To fix this, we will get igc64.dll version from the currenlty loaded graphics driver.
Test run: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/19313141656/job/55238243773#step:9:41
resolves #5440