-
Notifications
You must be signed in to change notification settings - Fork 76
capture-hw-details.sh: get igc64.dll version from the currenlty loaded graphics driver #5439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
643e77d
Get libigc version from Windows driver
kwasd 579e781
Show highest libigc version from the driver store
kwasd 44ee766
Get igc64.dll version from the currently loaded driver
kwasd 111995c
Use pwsh for libigc_version
kwasd f5a539b
Get igc version from dwm.exe
kwasd 2deffec
Merge branch 'main' into fix/windows-libigc-version
kwasd 79ebfbd
Fix powershell
kwasd af755b2
Fix quoting
kwasd 87223d5
Handle multiple dwms
kwasd 72dae64
Handle multiple dwms
kwasd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a possible scenario? I understand when it comes to
DriverStore(previous approach), which can contain multiple drivers, but we've switched to an approach where the driver currently in use is requested. Is it possible that multiple drivers are in use at the same time?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, after updating the driver, but before reboot, It lists 2 versions of igc64 loaded for dwm.exe. I suppose this it is done on purpose to allow fast fallback on driver crashes.
For example, see #5440 (comment).
However your comment highlighted another issue: when an interactive session is present on machine, this will return "MULTIPLE" despite there's only one library, since we have 2 dwms in this case: one for a login screen, and one for a session. I'll fix it with something like
sort -uThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it handles multiple objects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you plan to do if script return
MULTIPLE? Will this be a signal that the machine needs to be rebooted?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @kwasd