Skip to content

[SYCL] Fix coverity issues 11/11 2025 #20614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 21, 2025
Merged

[SYCL] Fix coverity issues 11/11 2025 #20614

merged 8 commits into from
Nov 21, 2025

Conversation

@steffenlarsen
Copy link
Contributor

@steffenlarsen steffenlarsen commented Nov 11, 2025

This commit makes the following changes to sate Coverity:

  1. Initializes uninitialized variables. This mainly affects UR handles that are expected to be set after their corresponding UR calls.
  2. Catch exceptions in dtors, similar to how we do for *_impl classes.
  3. Fix use-after-move cases and set more appropriate ownerships.
  4. Change a selection of arguments to const references.

@steffenlarsen
[SYCL] Fix coverity issues 11/11 2025
7cd4c59 
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen requested a review from a team as a code owner November 11, 2025 16:00
vinser52
vinser52 requested changes Nov 11, 2025
View reviewed changes
sycl/source/detail/queue_impl.cpp
KData.getNDRDesc(), std::move(HostKernelPtr),
nullptr, // Kernel
nullptr, // KernelBundle
std::move(CGData), std::move(KData).getArgs(),
Copy link
Contributor

@vinser52 vinser52 Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove the std::move(KData).getArgs()?

Copy link
Contributor Author

@steffenlarsen steffenlarsen Nov 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KData is used in the following arguments. That's a use-after-move.

Copy link
Contributor

@vinser52 vinser52 Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we do not move the KData itself here. Such syntax forces calling of the right overload of getArgs() that does the move of args. With your change it will be a copy instead of move.

Copy link
Contributor Author

@steffenlarsen steffenlarsen Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I was not aware of that syntax... And I suppose neither is Coverity. 😆

I still have concerns regarding it, but I can revert it here and we can discuss it in #20617 (comment).

@steffenlarsen steffenlarsen mentioned this pull request Nov 12, 2025
Merged
@steffenlarsen
Revert removal of moving KData args
11a7046 
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen
Revert DepEvents change in favor of future refactoring
accc1c5 
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen
Copy link
Contributor Author

steffenlarsen commented Nov 21, 2025

@vinser52 - Have all your concerns been addressed?

@steffenlarsen steffenlarsen merged commit 72c54ee into intel:sycl Nov 21, 2025
56 of 61 checks passed
@aelovikov-intel aelovikov-intel mentioned this pull request Nov 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinser52 vinser52 vinser52 approved these changes

@slawekptak slawekptak slawekptak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@steffenlarsen @vinser52 @slawekptak