-
Notifications
You must be signed in to change notification settings - Fork 13
chore: Upgrading Kubebuilder to V4 #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: Upgrading Kubebuilder to V4 #30
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: holgerson97 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It’s fine to do these two changes in a single PR (as two separate commits), thanks. But it seems to me the merge is going in the wrong direction: here everything is added in |
@skitt I think my question was not straightforward enough, basically it was about the rescaffolding in this PR, I added now the changes in 7c82e36 |
Rescaffolding of project to root dir Removed old ClusterProperty folder
3e3cfdb
to
7c82e36
Compare
we still need the generated client |
@skitt sorry for this taking so long, can you rereview? |
actually we need the generated client, it cannot be deleted. I have another PR that to update the existing one right now...#31 |
/sig multicluster |
My motivation for this PR is this discussion: Kubebuilder Discussion #3907
I also want to move the scaffolding into the root directory, is this something that is ok to be done in one PR?