Skip to content

Conversation

holgerson97
Copy link
Contributor

My motivation for this PR is this discussion: Kubebuilder Discussion #3907
I also want to move the scaffolding into the root directory, is this something that is ok to be done in one PR?

@k8s-ci-robot k8s-ci-robot requested a review from JeremyOT March 11, 2025 08:55
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: holgerson97
Once this PR has been reviewed and has the lgtm label, please assign lauralorenz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 11, 2025
@skitt
Copy link
Member

skitt commented Mar 18, 2025

It’s fine to do these two changes in a single PR (as two separate commits), thanks. But it seems to me the merge is going in the wrong direction: here everything is added in clusterproperty, I would have thought everything would end up in the root directory.

@holgerson97
Copy link
Contributor Author

holgerson97 commented Mar 20, 2025

It’s fine to do these two changes in a single PR (as two separate commits), thanks. But it seems to me the merge is going in the wrong direction: here everything is added in clusterproperty, I would have thought everything would end up in the root directory.

@skitt I think my question was not straightforward enough, basically it was about the rescaffolding in this PR, I added now the changes in 7c82e36

Rescaffolding of project to root dir

Removed old ClusterProperty folder
@holgerson97 holgerson97 force-pushed the chore/kubebuilder_v4 branch from 3e3cfdb to 7c82e36 Compare March 20, 2025 10:05
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2025
@qiujian16
Copy link
Contributor

we still need the generated client

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2025
@holgerson97
Copy link
Contributor Author

@skitt sorry for this taking so long, can you rereview?

@qiujian16
Copy link
Contributor

actually we need the generated client, it cannot be deleted. I have another PR that to update the existing one right now...#31

@lauralorenz
Copy link
Contributor

/sig multicluster

@k8s-ci-robot k8s-ci-robot added the sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. label Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants