-
Notifications
You must be signed in to change notification settings - Fork 13
[WIP] Generate client code with the consistent APIs #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think we want this the other way -- Remove See #12 which was the PR that purposely moved those files into the root to make it function as a Go module |
@lauralorenz are we fine to remove |
6e4e776
to
cf9a5d4
Compare
Signed-off-by: Jian Qiu <jqiu@redhat.com>
cf9a5d4
to
2e06e60
Compare
@lauralorenz PTAL again. |
# Kubernetes Generated files - skip generated files, except for vendored files | ||
|
||
!vendor/**/zz_generated.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think we want this — generated files do need to be stored in version control so that dependencies can use them, and we don’t want to exclude vendored generated files because that would prevent us from using them.
discussed with @holgerson97 , I will build client based on #30 when it is merged. |
/sig multicluster |
Uh oh!
There was an error while loading. Please reload this page.