Skip to content

Conversation

qiujian16
Copy link
Contributor

@qiujian16 qiujian16 commented Jul 29, 2025

  1. Remove the previous duplicated API definition.
  2. move the client generate script to clusterproperty directory.
  3. upgrade k8s deps to 1.32
  4. update makefile

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qiujian16
Once this PR has been reviewed and has the lgtm label, please assign jeremyot for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from JeremyOT July 29, 2025 08:08
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 29, 2025
@k8s-ci-robot k8s-ci-robot requested a review from lauralorenz July 29, 2025 08:08
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 29, 2025
@lauralorenz
Copy link
Contributor

I think we want this the other way --

Remove clusterproperty/ duplicate and keep the root "duplicate".

See #12 which was the PR that purposely moved those files into the root to make it function as a Go module

@qiujian16
Copy link
Contributor Author

@lauralorenz are we fine to remove clusterproperty/ now. Currently we have beta API defined only in clusterproperty/

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@qiujian16
Copy link
Contributor Author

@lauralorenz PTAL again.

Comment on lines +18 to +20
# Kubernetes Generated files - skip generated files, except for vendored files

!vendor/**/zz_generated.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think we want this — generated files do need to be stored in version control so that dependencies can use them, and we don’t want to exclude vendored generated files because that would prevent us from using them.

@qiujian16
Copy link
Contributor Author

discussed with @holgerson97 , I will build client based on #30 when it is merged.

@lauralorenz
Copy link
Contributor

/sig multicluster

@k8s-ci-robot k8s-ci-robot added the sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. label Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants