Support L2 cache clearing in do_bench_cudagraph #8384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yf225
force-pushed
the
do_bench_cudagraph_cache_clear
branch
from
bd5ed9e to
9943a49
Compare
|
It seems fine to me as the default is False. What do you think? @ThomasRaoux @peterbell10 |
peterbell10
reviewed
Oct 7, 2025
| for x in grad_to_none: | ||
| x.grad = None | ||
| maybe_clear_cache() | ||
| fn() |
There was a problem hiding this comment.
It's a bit weird to have the cache flushing time included in the benchmark measurement. I suppose for autotuning purposes it should be fine as all calls are effected the same way, but there should at least be a warning in the doc string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different from
triton.testing.do_bench,triton.testing.do_bench_cudagraphcurrently does not have L2 cache clearing (which is useful for measuring performance in cache-miss scenario common in real-world model training/inference). This PR addsclear_cacheoption arg to allow L2 cache clearing indo_bench_cudagraph.I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/python/testfor end-to-end tests