react-native: simplify source map processing flow #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konraddysput
force-pushed
the
feature/source-map-simplification
branch
4 times, most recently
from
73bfaa7 to
fd067d8
Compare
perf2711
reviewed
Jan 21, 2025
Contributor
perf2711
left a comment
perf2711
left a comment
There was a problem hiding this comment.
Can you add a description of setting this up in the React Native SDK README?
konraddysput
force-pushed
the
feature/source-map-simplification
branch
from
44f79ca to
c5c61f4
Compare
rick-bt
reviewed
Jan 21, 2025
rick-bt
reviewed
Jan 21, 2025
rick-bt
reviewed
Jan 21, 2025
rick-bt
reviewed
Jan 21, 2025
melekr
reviewed
Jan 21, 2025
examples/sdk/reactNative/ios/reactNative.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
examples/sdk/reactNative/ios/reactNative.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
rick-bt
approved these changes
Jan 21, 2025
konraddysput
force-pushed
the
feature/source-map-simplification
branch
from
b3b1bd0 to
103c50d
Compare
perf2711
reviewed
Jan 23, 2025
perf2711
approved these changes
Jan 23, 2025
Base automatically changed from
feature/sourcemap-tools-process-source
to
main
January 23, 2025 14:48
melekr
approved these changes
Jan 23, 2025
konraddysput
force-pushed
the
feature/source-map-simplification
branch
from
9aacf73 to
06a7ea4
Compare
… environment variable read
…rce map upload script
…ocess source map via node, not via jq
Co-authored-by: Sebastian Alex <sebapotok@gmail.com>
konraddysput
force-pushed
the
feature/source-map-simplification
branch
2 times, most recently
from
7dc3f3c to
91876c3
Compare
… to them in readme/xcode
konraddysput
force-pushed
the
feature/source-map-simplification
branch
from
91876c3 to
4c9c1b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This pull request simplifies the source map processing flow by adding source map support via metro.
In addition to that, on:
Android
There is a new gradle task that uploads a source map file in the end of the build/assemble process
iOS
the xcode build phase is now simpler and requires less execution.
Since we wanted to have simple and similar flows in both OSes, we wanted to continue with metro and adjust each build with new requirements.
ref: BT-5175