Add a option to force currentUser update to getSessionCurrentUser

[Oksamies]

No description provided.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 09-17-add_a_option_to_force_currentuser_update_to_getsessioncurrentuser

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Oksamies]

• Separate and organize root.tsx to multiple files #1550
• Enable teams, team settigns and user settings pages #1544
• Correct API fetch params and data in few settings actions #1543
• Update thunderstore-api to match up coming cyberstorm API changes #1542
• Add forced currentUser update to settings and teams pages #1535
• Add a option to force currentUser update to getSessionCurrentUser #1541 👈 (View in Graphite)
• Ensure current user is updated #1540
• Fix session revalidation corner case #1539
• Fix setSsion stale value set #1538
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[anttimaki]

Not a blocker but would be mighty cool of you if you'd at least consider doing the suggested changes if they make sense to you. And "it can be done later" is a cheap copout.

[anttimaki]

Nitpicks:

1. There's no need to read isStale if forceUpdateCurrentUser is true
2. The pattern of !(x === y) sort of read out like no(yes), which IMO is a bit confusing. Why not just use x !== y?
3. Using the strict equality operator (===) in isStale === "no" already checks for the type, so the check with typeof is redundant

Put together, this would reduce into

if (forceUpdateCurrentUser || _storage.safeGetValue(STALE_KEY) !== "no") {

Is guaranteed to return either "yes" or "no" (i.e. no undefined oslt), it might be better to use _storage.safeGetValue(STALE_KEY) === "yes" to avoid that "not 'no'" scenario again.

[Oksamies]

ESLint and CodeQL checks are failing because Graphite created a temporary branch when I was fixing and submitting code in each PR in order. (someone has limited the maximum amount of pushes to 2 in a single command and graphite normally tries to do the whole stack at once to prevent needing to create temporary branches)