-
Couldn't load subscription status.
- Fork 5
Update thunderstore-api to match up coming cyberstorm API changes #1542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update thunderstore-api to match up coming cyberstorm API changes #1542
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| useSession: true, | ||
| }, | ||
| requestSchema: undefined, | ||
| requestSchema: userLinkedAccountDisconnectRequestParamsSchema, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The requestSchema parameter is set to userLinkedAccountDisconnectRequestParamsSchema, but this appears to be a mismatch. This schema is defined for validating URL parameters, not the request body. Since the function doesn't send a request body (there's no body: JSON.stringify(data) in the request configuration), the requestSchema should be set to undefined. Alternatively, if request validation is needed, a proper request body schema should be defined separately from the URL parameter schema.
| requestSchema: userLinkedAccountDisconnectRequestParamsSchema, | |
| requestSchema: undefined, |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
bd91070 to
e6fba84
Compare
cbe1789 to
e3a6579
Compare
e3a6579 to
6ae0418
Compare
e6fba84 to
0ef1a10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
6ae0418 to
0fda05d
Compare
0ef1a10 to
c9789f0
Compare
| useSession: true, | ||
| }, | ||
| requestSchema: undefined, | ||
| requestSchema: userLinkedAccountDisconnectRequestDataSchema, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The requestSchema is set to userLinkedAccountDisconnectRequestDataSchema but the function no longer extracts or uses the 'data' parameter from props (line 15 only destructures config and params). This will cause the schema validation to fail since no request body data is being passed to apiFetch, but the schema expects a body with a 'provider' field. Either remove the requestSchema (set to undefined) or add back data extraction and body serialization.
| requestSchema: userLinkedAccountDisconnectRequestDataSchema, | |
| requestSchema: undefined, |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
The shape was the same, but it was using the requestParams schema, which can lead to bugs, if those are not the same in some point in the future
0fda05d to
1537ac3
Compare
449218f to
a85e496
Compare

No description provided.