Skip to content

Conversation

@Oksamies
Copy link
Contributor

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Sep 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 09-17-update_thunderstore-api_to_match_up_coming_cyberstorm_api_changes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

useSession: true,
},
requestSchema: undefined,
requestSchema: userLinkedAccountDisconnectRequestParamsSchema,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requestSchema parameter is set to userLinkedAccountDisconnectRequestParamsSchema, but this appears to be a mismatch. This schema is defined for validating URL parameters, not the request body. Since the function doesn't send a request body (there's no body: JSON.stringify(data) in the request configuration), the requestSchema should be set to undefined. Alternatively, if request validation is needed, a proper request body schema should be defined separately from the URL parameter schema.

Suggested change
requestSchema: userLinkedAccountDisconnectRequestParamsSchema,
requestSchema: undefined,

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@Oksamies Oksamies mentioned this pull request Sep 17, 2025
@Oksamies Oksamies changed the base branch from 09-16-enable_user_and_team_settings_pages to graphite-base/1542 September 18, 2025 16:05
@Oksamies Oksamies force-pushed the 09-17-update_thunderstore-api_to_match_up_coming_cyberstorm_api_changes branch from bd91070 to e6fba84 Compare September 18, 2025 16:47
@Oksamies Oksamies changed the base branch from graphite-base/1542 to 09-16-enable_user_and_team_settings_pages September 18, 2025 16:47
@Oksamies Oksamies changed the base branch from 09-16-enable_user_and_team_settings_pages to graphite-base/1542 September 18, 2025 17:29
@Oksamies Oksamies force-pushed the 09-17-update_thunderstore-api_to_match_up_coming_cyberstorm_api_changes branch from e6fba84 to 0ef1a10 Compare September 18, 2025 17:29
@Oksamies Oksamies changed the base branch from graphite-base/1542 to 09-16-enable_user_and_team_settings_pages September 18, 2025 17:30
Copy link
Contributor

@VilppeRiskidev VilppeRiskidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Oksamies Oksamies changed the base branch from 09-16-enable_user_and_team_settings_pages to graphite-base/1542 September 19, 2025 11:19
@Oksamies Oksamies force-pushed the 09-17-update_thunderstore-api_to_match_up_coming_cyberstorm_api_changes branch from 0ef1a10 to c9789f0 Compare September 19, 2025 11:19
@Oksamies Oksamies changed the base branch from graphite-base/1542 to 09-16-enable_user_and_team_settings_pages September 19, 2025 11:20
useSession: true,
},
requestSchema: undefined,
requestSchema: userLinkedAccountDisconnectRequestDataSchema,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requestSchema is set to userLinkedAccountDisconnectRequestDataSchema but the function no longer extracts or uses the 'data' parameter from props (line 15 only destructures config and params). This will cause the schema validation to fail since no request body data is being passed to apiFetch, but the schema expects a body with a 'provider' field. Either remove the requestSchema (set to undefined) or add back data extraction and body serialization.

Suggested change
requestSchema: userLinkedAccountDisconnectRequestDataSchema,
requestSchema: undefined,

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

The shape was the same, but it was using the requestParams schema, which can lead to bugs, if those are not the same in some point in the future
@Oksamies Oksamies force-pushed the 09-16-enable_user_and_team_settings_pages branch from 0fda05d to 1537ac3 Compare September 23, 2025 12:57
@Oksamies Oksamies force-pushed the 09-17-update_thunderstore-api_to_match_up_coming_cyberstorm_api_changes branch from 449218f to a85e496 Compare September 23, 2025 12:57
Base automatically changed from 09-16-enable_user_and_team_settings_pages to master September 23, 2025 13:04
@Oksamies Oksamies merged commit 8b08754 into master Sep 23, 2025
32 of 33 checks passed
@Oksamies Oksamies deleted the 09-17-update_thunderstore-api_to_match_up_coming_cyberstorm_api_changes branch September 23, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants