Skip to content

Conversation

@Oksamies
Copy link
Contributor

@Oksamies Oksamies commented Sep 17, 2025

Look at the commits for more information

@coderabbitai
Copy link

coderabbitai bot commented Sep 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Introduces package version pages with community-scoped and non-community routes, including loaders, clientLoaders, and shouldRevalidate logic. Adds tabs for Readme, Required (placeholder), and Versions, using Suspense/Await and shared components. Extends routing, breadcrumbs, and link libraries to support new v/{version} paths. Implements semver-based table sorting and common action/link components. Expands DapperTs and Thunderstore API with getPackageVersionDetails endpoint, request/response schemas, and fake data support. Updates utility functions, a package listing revalidation check, and dev proxy for /p paths. Exposes additional schema (packageTeamSchema) and link interfaces.

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The description is just a generic prompt to view commits and does not summarize or contextualize any of the changes made in the PR. Provide a concise summary of the key changes and objectives directly in the PR description so reviewers understand the scope without inspecting individual commits.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly identifies that the PR adds pages related to package versions, which aligns directly with the main changes in the diff.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Oksamies Oksamies changed the base branch from 09-17-update_thunderstore-api_to_match_up_coming_cyberstorm_api_changes to graphite-base/1547 September 18, 2025 16:47
@Oksamies Oksamies force-pushed the 09-18-add_package_version_pages branch from 895c5a8 to 4582600 Compare September 18, 2025 16:47
@Oksamies Oksamies changed the base branch from graphite-base/1547 to 09-17-update_thunderstore-api_to_match_up_coming_cyberstorm_api_changes September 18, 2025 16:47
@Oksamies Oksamies changed the base branch from 09-17-update_thunderstore-api_to_match_up_coming_cyberstorm_api_changes to graphite-base/1547 September 18, 2025 17:29
@Oksamies Oksamies force-pushed the 09-18-add_package_version_pages branch from 4582600 to b1e3d73 Compare September 18, 2025 17:30
@Oksamies Oksamies changed the base branch from graphite-base/1547 to 09-17-update_thunderstore-api_to_match_up_coming_cyberstorm_api_changes September 18, 2025 17:30
@Oksamies Oksamies force-pushed the 09-18-add_package_version_pages branch from b1e3d73 to e6817ad Compare September 18, 2025 20:03
@Oksamies Oksamies changed the base branch from 09-17-update_thunderstore-api_to_match_up_coming_cyberstorm_api_changes to graphite-base/1547 September 19, 2025 11:19
@Oksamies Oksamies force-pushed the 09-18-add_package_version_pages branch from e6817ad to e6956ff Compare September 19, 2025 11:21
@Oksamies Oksamies changed the base branch from graphite-base/1547 to 09-17-update_thunderstore-api_to_match_up_coming_cyberstorm_api_changes September 19, 2025 11:21
@Oksamies Oksamies changed the base branch from 09-17-update_thunderstore-api_to_match_up_coming_cyberstorm_api_changes to graphite-base/1547 September 19, 2025 12:49
@Oksamies Oksamies force-pushed the 09-18-add_package_version_pages branch from e6956ff to 73cc06b Compare September 19, 2025 12:49
@Oksamies Oksamies changed the base branch from graphite-base/1547 to 09-17-update_thunderstore-api_to_match_up_coming_cyberstorm_api_changes September 19, 2025 12:50
@Oksamies Oksamies force-pushed the 09-18-add_package_version_pages branch from 73cc06b to 7a9bbdb Compare September 19, 2025 14:47
@Oksamies Oksamies changed the title Add Version Detail api endpoint to thunderstore-api Package Version pages Sep 19, 2025
@Oksamies Oksamies marked this pull request as ready for review September 19, 2025 14:49
@Oksamies Oksamies force-pushed the 10-03-add_getpackageversiondependencies_to_dapper_and_dapperfake branch from f2b44fd to b771417 Compare October 8, 2025 16:13
@Oksamies Oksamies force-pushed the 09-18-add_package_version_pages branch 2 times, most recently from 8a09bb9 to d492dde Compare October 8, 2025 16:14
@Oksamies Oksamies force-pushed the 10-03-add_getpackageversiondependencies_to_dapper_and_dapperfake branch from b771417 to 1588273 Compare October 8, 2025 16:14
@Oksamies Oksamies force-pushed the 09-18-add_package_version_pages branch from d492dde to fc31199 Compare October 8, 2025 16:24
@Oksamies Oksamies force-pushed the 10-03-add_getpackageversiondependencies_to_dapper_and_dapperfake branch 2 times, most recently from f303680 to e9e6941 Compare October 10, 2025 09:22
@Oksamies Oksamies force-pushed the 09-18-add_package_version_pages branch 2 times, most recently from 88fc299 to 070be15 Compare October 10, 2025 09:38
@Oksamies Oksamies force-pushed the 10-03-add_getpackageversiondependencies_to_dapper_and_dapperfake branch from e9e6941 to 93a2bdc Compare October 10, 2025 09:39
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 1.77268% with 1884 lines in your changes missing coverage. Please review.
✅ Project coverage is 9.94%. Comparing base (8ec06d5) to head (c6891dd).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
apps/cyberstorm-remix/app/p/packageVersion.tsx 0.22% 435 Missing ⚠️
...orm-remix/app/p/packageVersionWithoutCommunity.tsx 0.25% 389 Missing ⚠️
...ts/PaginatedDependencies/PaginatedDependencies.tsx 0.00% 135 Missing ⚠️
...mix/app/p/tabs/Versions/PackageVersionVersions.tsx 0.00% 113 Missing ⚠️
...ersions/PackageVersionWithoutCommunityVersions.tsx 0.00% 110 Missing ⚠️
...m-remix/app/p/tabs/Readme/PackageVersionReadme.tsx 0.00% 74 Missing ⚠️
...bs/Readme/PackageVersionWithoutCommunityReadme.tsx 0.00% 74 Missing ⚠️
...mix/app/p/tabs/Required/PackageVersionRequired.tsx 0.00% 65 Missing ⚠️
...equired/PackageVersionWithoutCommunityRequired.tsx 0.00% 65 Missing ⚠️
packages/dapper-fake/src/fakers/package.ts 0.00% 59 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1547      +/-   ##
=========================================
- Coverage   10.64%   9.94%   -0.70%     
=========================================
  Files         288     302      +14     
  Lines       20587   22358    +1771     
  Branches      386     398      +12     
=========================================
+ Hits         2191    2223      +32     
- Misses      18396   20135    +1739     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Oksamies Oksamies force-pushed the 09-18-add_package_version_pages branch 2 times, most recently from 95684c0 to 780f303 Compare October 13, 2025 11:10
@Oksamies Oksamies force-pushed the 10-03-add_getpackageversiondependencies_to_dapper_and_dapperfake branch from 93a2bdc to 23438e8 Compare October 13, 2025 11:10
…cies, and versions

- Implemented `PackageVersionReadme` and `PackageVersionWithoutCommunityReadme` components for displaying package readme content.
- Created `PackageVersionRequired` and `PackageVersionWithoutCommunityRequired` components to show required dependencies for specific package versions.
- Developed `PackageVersionVersions` and `PackageVersionWithoutCommunityVersions` components to list available versions of a package.
- Updated routing to support new package version detail pages, including community and non-community versions.
- Enhanced link library to include new links for package version details, required dependencies, and versions.
- Refactored existing components to improve code organization and maintainability.
@Oksamies Oksamies force-pushed the 09-18-add_package_version_pages branch from 780f303 to c6891dd Compare October 13, 2025 12:09
@Oksamies Oksamies force-pushed the 10-03-add_getpackageversiondependencies_to_dapper_and_dapperfake branch from 23438e8 to 8ec06d5 Compare October 13, 2025 12:09
Base automatically changed from 10-03-add_getpackageversiondependencies_to_dapper_and_dapperfake to 10-03-add_fetchpackageversiondependencies_function_to_thunderstore-api October 13, 2025 12:30
Base automatically changed from 10-03-add_fetchpackageversiondependencies_function_to_thunderstore-api to master October 13, 2025 12:41
@Oksamies Oksamies merged commit dc25f43 into master Oct 13, 2025
37 of 41 checks passed
@Oksamies Oksamies deleted the 09-18-add_package_version_pages branch October 13, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants