Correct API fetch params and data in few settings actions

[Oksamies]

Correct the params and data in connection Disconnect
Correct the params and data in service account remove

Summary by CodeRabbit

• Bug Fixes

  • Improved reliability when removing service accounts to prevent failures during deletion.
  • Streamlined disconnecting third-party connections; no longer requires username, ensuring more consistent behavior.

• Refactor

  • Adjusted request formatting for account-related actions to align with backend expectations, improving stability without changing user workflows.

[coderabbitai]

Walkthrough

Two UI components update how they form API requests: one moves a service account identifier from request body to URL params; the other moves provider from URL params to request body and removes user from params. No exported interfaces changed.

Changes

Cohort / File(s)	Summary
API request payload/params adjustments apps/cyberstorm-remix/app/settings/teams/team/tabs/ServiceAccounts/ServiceAccounts.tsx, apps/cyberstorm-remix/app/settings/user/Connections/Connections.tsx	ServiceAccounts: send uuid in route params; empty body for removal. Connections: remove user from params; include { provider } in body and only provider in params for disconnect. No signature changes.

Sequence Diagram(s)

sequenceDiagram
  participant UI as Settings UI
  participant API as Backend API

  rect rgba(200,235,255,0.25)
    note over UI,API: Service Account Removal (changed)
    UI->>API: DELETE /service-accounts/:uuid\nBody: {}
    API-->>UI: 200/4xx
  end

  rect rgba(220,255,220,0.25)
    note over UI,API: User Connection Disconnect (changed)
    UI->>API: POST /connections/disconnect?provider=:p\nBody: { provider: p }
    API-->>UI: 200/4xx
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my whiskers at shifting streams,
Params hop paths, payloads find new seams.
URLs nibble uuids with care,
Bodies carry providers to share.
In tidy burrows of code we dwell—
small hops, clean trails, all’s well. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title concisely describes the primary change — correcting API fetch params and request data in settings actions — and maps to the edits shown (service account removal and connection disconnect), so it accurately reflects the changeset while remaining short and focused.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 09-17-correct_api_fetch_params_and_data_in_few_settings_actions

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b08754 and 5d42bcd.

📒 Files selected for processing (2)

• apps/cyberstorm-remix/app/settings/teams/team/tabs/ServiceAccounts/ServiceAccounts.tsx (1 hunks)
• apps/cyberstorm-remix/app/settings/user/Connections/Connections.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Test
• GitHub Check: Generate visual diffs
• GitHub Check: Generate visual diffs
• GitHub Check: CodeQL

🔇 Additional comments (2)

apps/cyberstorm-remix/app/settings/teams/team/tabs/ServiceAccounts/ServiceAccounts.tsx (1)

160-169: LGTM — uuid param is correct and DELETE has no body

teamServiceAccountRemove uses params.team_name and params.uuid in its path and request params schema, so passing uuid: serviceAccount.identifier is correct.

apps/cyberstorm-remix/app/settings/user/Connections/Connections.tsx (1)

126-133: Keep provider in both params and body — the endpoint requires both

The delete endpoint builds the path with params.provider (/api/cyberstorm/user/linked-account/${params.provider}/disconnect/) and its request schema also validates provider in the body (userLinkedAccountDisconnectRequestDataSchema), so keep both. See packages/thunderstore-api/src/delete/userLinkedAccountDisconnect.ts and packages/thunderstore-api/src/schemas/requestSchemas.ts.

Likely an incorrect or invalid review comment.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Oksamies]

• Separate and organize root.tsx to multiple files #1550
• Enable teams, team settigns and user settings pages #1544
• Correct API fetch params and data in few settings actions #1543 👈 (View in Graphite)
• Update thunderstore-api to match up coming cyberstorm API changes #1542
• Add forced currentUser update to settings and teams pages #1535
• Add a option to force currentUser update to getSessionCurrentUser #1541
• Ensure current user is updated #1540
• Fix session revalidation corner case #1539
• Fix setSsion stale value set #1538
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[VilppeRiskidev]

Nice 👍